Add performance skills: measurement + React/Redux anti-pattern reviews#43
Open
MajorLift wants to merge 2 commits into
Open
Add performance skills: measurement + React/Redux anti-pattern reviews#43MajorLift wants to merge 2 commits into
MajorLift wants to merge 2 commits into
Conversation
MajorLift
added a commit
that referenced
this pull request
Jun 10, 2026
- WDYR (`wdyr.js`, `useSelector` diff tracking) as the live cascade tracer - input-unstable vs output-unstable tool selection (`resultEqualityCheck`) - a live cascade nullifies downstream memo/virtualization/compiler wins - plain-function selector sweep; span quota guardrail; redux-persist caveat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds to the
performancedomain in two halves: measuring a performance change, and catching at review time the React/Redux anti-patterns that cause regressions.Why for the extension: the extension is a large React/Redux app where
useEffectand selector anti-patterns drive render-cascade regressions. These review skills catch those anti-patterns in an extension PR diff before merge, and are the review-time counterpart to the extension's existingperf-*optimization skills.Measurement
data-analysis— turn raw performance data into a defensible before/after.metrics-pipeline-design; web-vitals (runtime-metrics,production-vs-benchmarks,attribution-import).Review — the counterpart to the existing
perf-*optimization skillseffect-anti-pattern-review— catchuseEffectanti-patterns in a PR diff (counterpart toperf-hooks-effects).selector-anti-pattern-review— catch Redux selector anti-patterns in a diff (counterpart toperf-state-management), with extension/mobile overlays.render-cascade,effect-anti-patterns,selector-anti-patterns.CHANGELOG updated; commits GPG-signed.